feat(s3): add copy method to S3Template#1656
Open
abilng wants to merge 1 commit into
Open
Conversation
Allow copying objects between buckets/keys via S3Operations without dropping down to S3Client. Closes awspring#1157
abilng
requested review from
MatejNedic,
maciejwalkowiak and
tomazfernandes
as code owners
July 22, 2026 09:33
MatejNedic
requested changes
Jul 23, 2026
MatejNedic
left a comment
MatejNedic
left a comment
Member
There was a problem hiding this comment.
Hey @abilng ,
Thanks on PR, few changes needed.
| } | ||
|
|
||
| void apply(CopyObjectRequest.Builder builder) { | ||
| builder.metadataDirective(MetadataDirective.REPLACE); |
Member
There was a problem hiding this comment.
Should be configurable as well. Someone might want to override only if no value is set so .COPY
|
|
||
| void apply(CopyObjectRequest.Builder builder) { | ||
| builder.metadataDirective(MetadataDirective.REPLACE); | ||
| if (acl != null) { |
Member
There was a problem hiding this comment.
User ObjectProvider and set to builder instead of many ifs
Contributor
There was a problem hiding this comment.
Many ifs is consistent with other parts of this class. I think we can keep it in this PR and refactor independently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Allow copying objects between buckets/keys via S3Operations without dropping down to S3Client.
Closes #1157
📝 Checklist
🔮 Next steps